-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add logic to speed up permutation feature importance #4037
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4037 +/- ##
========================================
+ Coverage 68.8% 99.7% +31.0%
========================================
Files 349 349
Lines 37489 37523 +34
========================================
+ Hits 25763 37405 +11642
+ Misses 11726 118 -11608
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just requesting one additional coverage but looks great otherwise!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM once tests pass! great work 🦾
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! Nice work!
has_dfs
check in_supports_fast_permutation_importance