Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add logic to speed up permutation feature importance #4037

Merged
merged 12 commits into from
Mar 2, 2023

Conversation

ozzieD
Copy link
Contributor

@ozzieD ozzieD commented Feb 27, 2023

@CLAassistant
Copy link

CLAassistant commented Feb 27, 2023

CLA assistant check
All committers have signed the CLA.

@codecov
Copy link

codecov bot commented Feb 27, 2023

Codecov Report

Merging #4037 (62b1bf1) into main (a322411) will increase coverage by 31.0%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##            main   #4037      +/-   ##
========================================
+ Coverage   68.8%   99.7%   +31.0%     
========================================
  Files        349     349              
  Lines      37489   37523      +34     
========================================
+ Hits       25763   37405   +11642     
+ Misses     11726     118   -11608     
Impacted Files Coverage Δ
...ponents/transformers/preprocessing/featuretools.py 100.0% <100.0%> (+1.5%) ⬆️
evalml/pipelines/pipeline_base.py 98.5% <100.0%> (+0.1%) ⬆️
evalml/tests/component_tests/test_featuretools.py 100.0% <100.0%> (+100.0%) ⬆️
...understanding_tests/test_permutation_importance.py 100.0% <100.0%> (ø)
evalml/automl/automl_search.py 99.6% <0.0%> (+0.2%) ⬆️
...elines/components/transformers/column_selectors.py 92.9% <0.0%> (+1.5%) ⬆️
evalml/utils/gen_utils.py 99.3% <0.0%> (+1.5%) ⬆️
evalml/objectives/standard_metrics.py 100.0% <0.0%> (+1.7%) ⬆️
...onents/estimators/regressors/catboost_regressor.py 100.0% <0.0%> (+2.3%) ⬆️
... and 177 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ozzieD ozzieD changed the title Draft: add logic to speed up permutation feature importance add logic to speed up permutation feature importance Feb 28, 2023
Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just requesting one additional coverage but looks great otherwise!

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once tests pass! great work 🦾

Copy link
Contributor

@tamargrey tamargrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! Nice work!

@ozzieD ozzieD merged commit df29850 into main Mar 2, 2023
@ozzieD ozzieD deleted the 4036-dfs-trans-fast-perm-FI branch March 2, 2023 21:39
@chukarsten chukarsten mentioned this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_fast_permutation_importance doesn't run if DFS Transformer present, even when dfs feature pre-exist.
4 participants