Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap nb sphinx #4071

Merged
merged 3 commits into from
Mar 13, 2023
Merged

Cap nb sphinx #4071

merged 3 commits into from
Mar 13, 2023

Conversation

jeremyliweishih
Copy link
Collaborator

Fixes #4070

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #4071 (a1438a3) into main (9d8082d) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #4071   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        349     349           
  Lines      37514   37514           
=====================================
  Hits       37396   37396           
  Misses       118     118           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@eccabay eccabay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you file a followup issue to track figuring out what broke and unpinning in the future?

@jeremyliweishih
Copy link
Collaborator Author

@eccabay filed #4073.

@jeremyliweishih jeremyliweishih merged commit 2401d30 into main Mar 13, 2023
@jeremyliweishih jeremyliweishih deleted the cap_nb_sphinx branch March 13, 2023 18:24
@chukarsten chukarsten mentioned this pull request Mar 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cap nb-sphinx < 0.9.0
3 participants