Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphviz installation for windows workflows #4088

Merged
merged 2 commits into from
Mar 21, 2023
Merged

Conversation

eccabay
Copy link
Contributor

@eccabay eccabay commented Mar 20, 2023

Fixes #4089

Installation method copied from featuretools, since it works for them.

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #4088 (92382de) into main (4f2e9f6) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main   #4088   +/-   ##
=====================================
  Coverage   99.7%   99.7%           
=====================================
  Files        349     349           
  Lines      37548   37548           
=====================================
  Hits       37429   37429           
  Misses       119     119           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@eccabay eccabay marked this pull request as ready for review March 20, 2023 14:44
Copy link
Contributor

@christopherbunn christopherbunn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ty for doing this!

Copy link
Collaborator

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@eccabay eccabay merged commit 75932ab into main Mar 21, 2023
@eccabay eccabay deleted the graphviz-windows branch March 21, 2023 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix failing windows nightlies
3 participants