Change default action for invalid target data check #4131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4131 +/- ##
=======================================
+ Coverage 99.7% 99.7% +0.1%
=======================================
Files 349 349
Lines 37740 37752 +12
=======================================
+ Hits 37623 37635 +12
Misses 117 117
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
ParthivNaresh
requested review from
Cmancuso,
RezaAkhtar,
jeff-hernandez and
simha104
Cmancuso
reviewed
Apr 10, 2023
| data_check_name="InvalidTargetDataCheck", | ||
| parameters={ |
There was a problem hiding this comment.
This is testing the default action which is now drop rows, and the drop rows action doesn't have any of the parameters required by the impute column action
| data_check = InvalidTargetDataCheck("binary", "Log Loss Binary") | ||
| data_checks_output = data_check.validate(None, y) | ||
|
|
||
| action_pipeline = make_pipeline_from_data_check_output("binary", data_checks_output) |
There was a problem hiding this comment.
will be interesting to see how we fit these components or "datacheck pipelines" into our search pipelines!
RezaAkhtar
approved these changes
Apr 10, 2023
jeff-hernandez
approved these changes
Apr 10, 2023
| @@ -82,7 +82,7 @@ def validate(self, X, y): | |||
|
|
|||
| >>> X = pd.DataFrame({"col": [1, 2, 3, 1]}) | |||
| >>> y = pd.Series(["cat_1", "cat_2", "cat_1", "cat_2"]) | |||
| >>> target_check = InvalidTargetDataCheck("regression", "R2") | |||
| >>> target_check = InvalidTargetDataCheck("regression", "R2", null_strategy="impute") | |||
There was a problem hiding this comment.
it would be nice to keep the default behavior in the docstring. Can you file an issue for it?
jeremyliweishih
approved these changes
Apr 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4130
After creating the pull request: in order to pass the release_notes_updated check you will need to update the "Future Release" section of
docs/source/release_notes.rstto include this pull request by adding :pr:123.