Skip to content

Conversation

@frances-h
Copy link
Contributor


After creating the pull request: in order to pass the changelog_updated check you will need to update the "Future Release" section of docs/source/changelog.rst to include this pull request.

@frances-h frances-h requested a review from rwedge November 19, 2019 21:04
@codecov-io
Copy link

codecov-io commented Nov 19, 2019

Codecov Report

Merging #821 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #821   +/-   ##
=======================================
  Coverage   98.12%   98.12%           
=======================================
  Files         119      119           
  Lines       10875    10875           
=======================================
  Hits        10671    10671           
  Misses        204      204
Impacted Files Coverage Δ
featuretools/tests/testing_utils/mock_ds.py 100% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4877913...f2e65d5. Read the comment docs.

Copy link
Contributor

@rwedge rwedge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@frances-h frances-h merged commit 853091d into master Nov 19, 2019
@frances-h frances-h deleted the fix-ecommerce-nan branch November 19, 2019 21:42
@rwedge rwedge mentioned this pull request Nov 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants