Skip TensorFlow dependent tests if Tensorflow is not installed #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Not entirely sure, but I don't think you need to make any changes in test_elmo.py or test_universal_sentence_encoder.py as those filenames will also match against the strings in the skip_files list in conftest.py causing those files to get skipped entirely if tensorflow is not installed. I think.
rwedge
reviewed
Feb 18, 2022
|
I'm doing some similar work on featuretools right now EvalML did some work like this previously: alteryx/evalml#2922 I think there should be a way to run the unit tests without tensorflow installed, but the tensorflow tests should run (and fail) if tensorflow is not installed |
dvreed77
changed the title
rwedge
reviewed
Feb 18, 2022
|
Fixes #107 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip TensorFlow dependent tests
fixes #106