Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CountString and Whitespace primitive #89

Merged
merged 10 commits into from
Jan 7, 2022
Merged

Add CountString and Whitespace primitive #89

merged 10 commits into from
Jan 7, 2022

Conversation

tuethan1999
Copy link
Contributor

@tuethan1999 tuethan1999 commented Dec 29, 2021 •
edited by gsheni
Loading

Fixes #77

@CLAassistant
Copy link

CLAassistant commented Dec 29, 2021 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@gsheni gsheni changed the title add whitespace primitive Add Whitespace primitive Dec 30, 2021
@gsheni gsheni changed the title Add Whitespace primitive Add CountString and Whitespace primitive Jan 5, 2022
@gsheni gsheni requested a review from a team January 5, 2022 15:10
thehomebrewnerd
thehomebrewnerd reviewed Jan 5, 2022
View reviewed changes
Copy link
Contributor

@thehomebrewnerd thehomebrewnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add this update to the changelog as well.

nlp_primitives/tests/test_count_string.py Show resolved Hide resolved
nlp_primitives/tests/test_whitespace_count.py Show resolved Hide resolved
tamargrey
tamargrey approved these changes Jan 7, 2022
View reviewed changes
Copy link

@tamargrey tamargrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tuethan1999 tuethan1999 enabled auto-merge (squash) January 7, 2022 18:22
@tuethan1999 tuethan1999 merged commit e250744 into main Jan 7, 2022
@dvreed77 dvreed77 mentioned this pull request Feb 17, 2022
Merged
@rwedge rwedge deleted the whitespace_count branch June 16, 2022 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thehomebrewnerd thehomebrewnerd thehomebrewnerd left review comments

@tamargrey tamargrey tamargrey approved these changes

Assignees

@tuethan1999 tuethan1999

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add WhitespaceCount primitive
4 participants
@tuethan1999 @CLAassistant @thehomebrewnerd @tamargrey