Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use filter arg to safe extract archives #1862

Merged
merged 6 commits into from
May 13, 2024
Merged

Conversation

thehomebrewnerd
Copy link
Contributor

Closes #1860

The filter argument was added in these Python versions: 3.9.17, 3.10.12, 3.11.4, 3.12.0. If the user is running an older Python version an error will be thrown and they will need to upgrade to one of these patch releases (or newer) to extract the archive.

Copy link

codecov bot commented May 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.55%. Comparing base (762e08f) to head (8c2d4b4).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1862   +/-   ##
=======================================
  Coverage   98.55%   98.55%           
=======================================
  Files          98       98           
  Lines       10645    10684   +39     
=======================================
+ Hits        10491    10530   +39     
  Misses        154      154           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@jeremyliweishih jeremyliweishih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thehomebrewnerd thehomebrewnerd merged commit 27edbcd into main May 13, 2024
25 checks passed
@thehomebrewnerd thehomebrewnerd deleted the safe-deserialization branch May 13, 2024 15:47
@thehomebrewnerd thehomebrewnerd mentioned this pull request May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add filter arg to tarfile.extractall call to safely deserialize dataframes
2 participants