Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jQuery UI Selectmenu on iPhone not compatible with Fullscreen.js? #2436

Closed
cobwebmedia opened this issue Nov 29, 2016 · 15 comments
Closed

jQuery UI Selectmenu on iPhone not compatible with Fullscreen.js? #2436

cobwebmedia opened this issue Nov 29, 2016 · 15 comments

Comments

@cobwebmedia
Copy link

I'm using jquery-1.12.4.js, jquery-ui.js and the latest fullscreen.js code. Whilst Selectmenu is being recognised and successfully switching out with the usual styled HTML, on the iPhone (latest OS) selecting one of the options fails to propagate the value. All works fine on dektop - just seems to be an issue on iPhone.

Have commented out fullscreen.js and the functionality returns.

@alvarotrigo
Copy link
Owner

Closed until an isolated reproduction is provided as detailed in the reporting issues guidelines and the issue skeleton.

@cobwebmedia
Copy link
Author

Hi, I've now added my stripped down code to https://jsfiddle.net/kingrandolf/4m2aefgs/ - it is a little tricky trying to replicate this via JS Fiddle on the iPhone - I can send over a zip of my code if you'd prefer.

Incidentally I have been looking into this and I believe I know the source of the issue. When a section has more content than the available height the content gets wrapped with two divs (fp-scrollable and fp-scroller) - this seems to be what knocks it out. I have added a fixed height of 800px to the form, so if you remove this and reload you'll find the select works.

Thanks, and great script aside from this. Everything else is looking great.

Andy

@alvarotrigo
Copy link
Owner

Steps to replicate the issue?

@cobwebmedia
Copy link
Author

Hi, please access the stripped down version at https://www.andyhitchman.co.uk/scripts/fullpage-issue-2/ via any (physical) iPhone with latest OS. If you try to choose an option from the select it won't populate. However, remove the 800px height from the form and you'll notice the content no longer gets wrapped with those two divs and the select then works.

It doesn't have to be a physical height that triggers this either - if you add enough content to the section so its wrapped within the two divs you'll notice the issue arises too.

Find zip attached.

fullpage-issue-2.zip

Thanks

@alvarotrigo
Copy link
Owner

alvarotrigo commented Dec 5, 2016

Do you need to use scrollOverflow: true?

@alvarotrigo
Copy link
Owner

This is probably the very well known iScroll issue. Nothing to do with fullpage.js but with the library used when using scrollOverflow:true.

Related topics are #2260 and #2035

@cobwebmedia
Copy link
Author

I do, because the form will have more inputs and these push the inner content down past the bottom of the screen. I know I could choose not to use this for mobile but I've sorted through a number of issues to get the site working really smooth on mobile - I wouldn't want to give up at this last hurdle.

I'm surprised this issue hasn't been picked up before.

Do you have any ideas?

Thanks

@alvarotrigo
Copy link
Owner

alvarotrigo commented Dec 5, 2016

Do you have any ideas?

As i said in the previous comment. This is a iScroll issue, not a fullPage.js one.
Also, you can probably replicate this issue with just iScroll itself and your jQuery element.
See cubiq/iscroll#783

The iScrolll library has weird issues when it comes to buttons as well:
cubiq/iscroll#561

You might have to consider using and absolute positioned element for your menu instead. This won't create any scroll bar and might solve the problem

@cobwebmedia
Copy link
Author

cobwebmedia commented Dec 5, 2016 via email

@alvarotrigo
Copy link
Owner

I always recommend not to use scrollOverflow:true.
That's just a "hack".

@cobwebmedia
Copy link
Author

cobwebmedia commented Dec 5, 2016 via email

@alvarotrigo
Copy link
Owner

Also another option.
Then follow the docs and use fp-noscroll in that section.

@cobwebmedia
Copy link
Author

cobwebmedia commented Dec 5, 2016 via email

@intercode
Copy link

Hello,
I was having some problems to make a "chosen" select to work with scrollOverflow:true. I couldn't click on it. Using "fp-noscroll" on the section that has the form solved the problem. Thank you for the tip.

@alvarotrigo
Copy link
Owner

@intercode are you initializing chosen in the afterRender callback as suggested in the documentation and the Frequently Answered Questions?

This might be a bug in iScroll, check this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants