Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image is not redrawn on update #15

Closed
testower opened this issue Feb 11, 2020 · 2 comments
Closed

Image is not redrawn on update #15

testower opened this issue Feb 11, 2020 · 2 comments

Comments

@testower
Copy link

In reference to: #6 (comment)

The image does not seem to be redrawn after first render, even when the props change. Boxes update correctly, but the image stays the same. Even when passing "forceRedraw" prop doesn't help. Maybe I'm using this component incorrectly?

const ImageWithBoundingBoxes = ({ imageUrl, labels }) =>
  <BoundingBox
    forceRedraw
    image={imageUrl}
    boxes={labels}
    options={{
      colors: {
        normal: 'red',
        selected: 'rgba(0,225,204,1)',
        unselected: 'rgba(100,100,100,1)'
      },
      style: {
        maxWidth: '100%',
        maxHeight: '90vh'
      }
    }}
  />
@alx
Copy link
Owner

alx commented Feb 13, 2020

Hi @testower

I was able to create a new storybook story in order to reproduce this issue:

https://github.com/alx/react-bounding-box/tree/fix-image-redraw-issue-15

I'll let you know when it's corrected.

@alx
Copy link
Owner

alx commented Feb 13, 2020

thanks @testower , this issue has been fixe in v0.5.12

https://www.npmjs.com/package/react-bounding-box/v/0.5.12

@alx alx closed this as completed Feb 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants