Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding support for AppCompatActivity #96

Closed
octacode opened this issue Mar 17, 2017 · 2 comments
Closed

Adding support for AppCompatActivity #96

octacode opened this issue Mar 17, 2017 · 2 comments

Comments

@octacode
Copy link
Member

For the time being the activities don't support AppCompatActivity.

Benefits of using AppCompatActivity

It not only provide backwards compatibility to our app but also provides us the access to the Material Design Library too. After this we can easily add FloatingActionButtons, Snackbars, AlertDialogBoxes and other material design widgets easily which now we can't.

I'd be working on it.
@adithya321 adithya321 mentioned this issue Mar 17, 2017
Closed
@adithya321
Copy link
Contributor

Are you still working on this? If not, I would like to start working on it.

@octacode
Copy link
Member Author

Yes! I am working on the and soon will send a PR.

@octacode octacode mentioned this issue Mar 20, 2017
Merged
@cpg cpg closed this as completed in #120 Mar 20, 2017
cpg pushed a commit that referenced this issue Mar 20, 2017
@octacode @cpg
Added support for AppCompatActivity. (#120)
1076528 
fixes #96
@adithya321 adithya321 mentioned this issue Mar 22, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@adithya321 @octacode