-
-
Notifications
You must be signed in to change notification settings - Fork 123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(validateSingleCommit)!: check if the PR title matches the commit title #158
feat(validateSingleCommit)!: check if the PR title matches the commit title #158
Conversation
… title Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a fair point, thanks for the PR!
Honestly even if it can be seen as breaking, I feel like this just clears up confusion and makes the strange behaviour from Github a bit more transparent.
So personally I think we can get this merged in a minor release.
What do you think about a slightly more elaborative error message?
Co-authored-by: Jan Amann <jan@amann.me>
Signed-off-by: Kenji Miyake <kenji.miyake@tier4.jp>
🎉 This PR is included in version 4.1.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This update is breaking with dependabot.
|
It's fixed in v4.2.0 |
When we have a single semantic commit, even if we edit the PR title, it doesn't affect the squashed commit message. I think people usually don't want this behavior.
With this PR, we can ensure the PR title matches the commit title.
@amannn I believe this will break the current behavior, so could you tell me how do you feel about it? Should I implement another parameter for this?