Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enforce negative depth for nonplanar faces #190

Closed
ecoon opened this issue Apr 27, 2023 · 0 comments · Fixed by #197
Closed

enforce negative depth for nonplanar faces #190

ecoon opened this issue Apr 27, 2023 · 0 comments · Fixed by #197
Assignees
@ecoon

Comments

@ecoon
Copy link
Collaborator

ecoon commented Apr 27, 2023

depth_evaluator asserts if faces are nonplanar -- rather than use mesh.cell_centroid, define (for depth eval only) the cell centroid as average of face above and below centroids.
@ecoon ecoon self-assigned this Apr 27, 2023
ecoon added a commit that referenced this issue Jul 10, 2023
@ecoon
fixes bug in depth evaluator where depth can be negative for nonplana…
c3b239f 
…r-face columns. closes #190
@ecoon ecoon mentioned this issue Jul 10, 2023
Merged
ecoon added a commit that referenced this issue Jul 11, 2023
@ecoon
fixes bug in depth evaluator where depth can be negative for nonplana…
3d41a50 
…r-face columns. closes #190 (#197)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ecoon ecoon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixes bug in depth evaluator amanzi/ats
1 participant
@ecoon