Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

get reactive transport working in ATS master #56

Closed
ecoon opened this issue Aug 20, 2020 · 1 comment
Closed

get reactive transport working in ATS master #56

ecoon opened this issue Aug 20, 2020 · 1 comment
Assignees

Comments

@ecoon
Copy link
Collaborator

ecoon commented Aug 20, 2020

Clarify initialization of Chemistry and ATS

@ecoon

  • move chem_engine_->InitState() into setup?
  • move initial conditions state list into chemistry pk and out of state initial conditions list
  • make sure chemistry PK Initialize calls secondaryvariable update for saturation, anything else it needs in the dag
  • make sure flow + reactive transport inits flow before reactive transport

Fix Seg Faults in Alquimia + Amanzi

@ajkhattak

  • seg fault in AmanziChemistry::Alquimia_PK::CopyAlquimiaStateToAmanzi() (some missing setup of

Add Chemistry Regression Tests

@ahmad and @dasvyat

  • stream_decay_ingrowth.xml
@ecoon ecoon assigned ecoon, ajkhattak and dasvyat and unassigned ecoon Aug 20, 2020
@ecoon ecoon changed the title tweak order of initialization between Amanzi and ATS concepts get reactive transport working in ATS master Aug 20, 2020
@ecoon
Copy link
Collaborator Author

ecoon commented Nov 12, 2020

Capability is working as of #64

Tests still need work, but those should be tickets in other repos.

@ecoon ecoon closed this as completed Nov 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants