Add constant snow albedo as an option #235
Conversation
There was a problem hiding this comment.
Please parse the list beforehand -- calling isParameter() and get() in the innermost loop is a bad idea for performance reasons.
If you parse the list in the constructor, then have both a boolean, e.g.
bool is_constant_snow_albedo_ = plist_.isParameter(...);
double snow_albedo_ = plist_.get<double>(...);
Also, only add snow_dens to the list of dependencies if !is_constant_snow_albedo_ which will require some changes in the Evaluate method to only get and use the vector when you actually have it as a dependency, something like
Epetra_MultiVector* dens_snow = nullptr;
if (!is_constant_albedo_snow_) {
dens_snow = S_->Get(dens_snow_key_,...)->ViewComponent("cell").get();
}
Then, here you'll have something like:
albedo[2][c] = is_constant_snow_albedo_ ? snow_albedo_ : Relations::CalcSnowAlbedo((*snow_dens)[0][c]);
…nal dependency; rename snow emissivity
| @@ -81,7 +85,7 @@ AlbedoThreeComponentEvaluator::Evaluate_(const State& S, | |||
|
|
|||
| for (auto c : lc_ids) { | |||
| // albedo of the snow | |||
| albedo[2][c] = Relations::CalcAlbedoSnow(snow_dens[0][c]); | |||
| albedo[2][c] = is_constant_snow_albedo_ ? plist_.get<double>("albedo snow [-]") : Relations::CalcAlbedoSnow((*snow_dens)[0][c]); | |||
There was a problem hiding this comment.
No, also need to take this out. All parsing of the ParameterList must be done in the constructor. Also add
albedo_snow_ = plist_.get<double>("...");
in the constructor, then just use it here.
* Add constant snow albedo as an option * Add constant snow albedo as an option; use snow density as a conditional dependency; rename snow emissivity * Add the option of asking for constant snow albedo to constructor
No description provided.