-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update assets #825
Update assets #825
Conversation
BTW, this is still using with webpack v3, I'm already working on someupdates and changes for this on next PRs, although, this PR is required first 😅 |
Since .min.js and .bundle.js files are essentially compiled, why are we tracking those in the amber repo? |
You're right this is just an update of NPM/JS assets (to avoid vulnerability alerts on GH). I will remove them in my next PR about new For now I think this is ok 👍 |
@robacarp @faustinoaq we leave the compiled assets so that the site will display immediately without requiring npm to finish compiling. Any reason to remove them? |
@drujensen Yeah, that's a good reason. In my next PR (new For now, I think this is ok 👍 |
@drujensen I’m sorry, I forgot we’ve discussed this before at least once. I’m fine with that. My compulsion is to never commit compiled or transpiled code...but I remember the reason behind this now. |
Description of the Change
This PR does:
package.json
depedenciesamber.min.js
with latest dependenciespackage.json.ecr
templateamber new
and latest dependenciesAlternate Designs
No, this change is required by upcoming
amber watch
configurationBenefits
Fixes most NPM package vulnerabilities and prepare asset stuff for next PRs
Possible Drawbacks
No