[Controller Tests] Adds Missing HTTP Verbs #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faustinoaq
approved these changes
Apr 9, 2018
eliasjpr
force-pushed
the
ep/adds-http-verbs
branch
from
ebe94e3
to
4206aef
Compare
Issue: #10 Garnet should supports all the HTTP verbs available for simulating requests in a conntroller test. Currently is missing the Options, Trace, and Connect http verbs Adds missing HTTP Read Verbs to generate helper methods for testing controllers. With these changes Garnet has available all the HTTP verbs needed.
eliasjpr
force-pushed
the
ep/adds-http-verbs
branch
from
4206aef
to
d816ee8
Compare
faustinoaq
approved these changes
Apr 9, 2018
|
@amberframework/contributors need one more approval on this. |
robacarp
approved these changes
Apr 13, 2018
|
Thanks @eliasjpr :] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Garnet should supports all the HTTP verbs available for simulating
requests in a conntroller test. Currently is missing the Options, Trace,
and Connect http verbs
testing controllers.
With these changes Garnet has available all the HTTP verbs needed.