Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken remote-connection tests #595

Closed
ivelin opened this issue Mar 30, 2021 · 2 comments
Closed

Broken remote-connection tests #595

ivelin opened this issue Mar 30, 2021 · 2 comments
Assignees
@vickywane
Labels
released
Projects
Ambianic UI Agile Board

Comments

@ivelin
Copy link
Contributor

ivelin commented Mar 30, 2021

Describe the bug
Currently tests for the remote connection UI are dependant on the existence of hardcoded remote Peer ID which is not controlled by the CI. This is not a good practice for CI tests.

ambianic-ui/cypress/integration/ambianic-tests/remote-connection.spec.js

Line 29 in 2bf35b2

cy.get('#btn-sendRemotePeerID').click()

To Reproduce
See failing CI runs: https://github.com/ambianic/ambianic-ui/pull/594/checks?check_run_id=2224336786#step:5:3220

Expected behavior
Tests should be encapsulated in predictable environment that always behaves as expected. Ideally completely controlled by the CI flow.

Consider replacing the full p2p fetch API with a mockup local implementation that isolates the dependency on WebRTC. This way the Cypress UI tests do what they are meant to do.

End to end integration tests can be added later with a local edge peer running in the CI environment.
@ivelin ivelin added this to To do in Ambianic UI Agile Board via automation Mar 30, 2021
@ivelin
Copy link
Contributor Author

ivelin commented Sep 19, 2021

UPDATE: local edge peer is not needed to test UI functionality. Instead mock peer connection can be used.

@ivelin ivelin closed this as completed in 72f72ba Nov 3, 2021
Ambianic UI Agile Board automation moved this from To do to Done Nov 3, 2021
github-actions bot pushed a commit that referenced this issue Nov 3, 2021
@semantic-release-bot
chore(release): 2.21.0
d3bfe8e 
# [2.21.0](v2.20.0...v2.21.0) (2021-11-03)

### Features

* manage multiple edge devices in PWA ([#757](#757)) ([72f72ba](72f72ba)), closes [#758](#758) [#753](#753) [#741](#741) [#711](#711) [#705](#705) [#660](#660) [#659](#659) [#601](#601) [#595](#595) [#589](#589) [#563](#563) [#408](#408) [#370](#370) [#329](#329) [#327](#327) [#302](#302) [#299](#299)
@ivelin
Copy link
Contributor Author

ivelin commented Nov 3, 2021

🎉 This issue has been resolved in version 2.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ivelin ivelin added the released label Nov 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vickywane vickywane

Labels
released
Projects
Ambianic UI Agile Board
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ivelin @vickywane