Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rewrite Settings Screen to use peerConnectionStatus vuex state for displayed connection state. #711

Closed
vickywane opened this issue Aug 31, 2021 · 1 comment
Closed

Rewrite Settings Screen to use peerConnectionStatus vuex state for displayed connection state. #711

vickywane opened this issue Aug 31, 2021 · 1 comment
Assignees
@vickywane
Labels
enhancement New feature or request released

Comments

@vickywane
Copy link
Contributor

vickywane commented Aug 31, 2021 •
edited

Is your feature request related to a problem? Please describe.
Currently, this line of code within the Settings page has an if condition that evaluates to true when there is an edgePeerId. This should be corrected to use the peerConnectionStatus.

Describe the solution you'd like
This line of code should be rewritten to use the peerConnectionStatus to sync the connection state with the connection icon in the Navbar.

This feature request is a follow-up to this pull request.
Cc: @ivelin
@vickywane vickywane self-assigned this Aug 31, 2021
@vickywane vickywane added the enhancement New feature or request label Aug 31, 2021
This was referenced Aug 31, 2021
Merged
Closed
@ivelin ivelin closed this as completed in 72f72ba Nov 3, 2021
github-actions bot pushed a commit that referenced this issue Nov 3, 2021
@semantic-release-bot
chore(release): 2.21.0
d3bfe8e 
# [2.21.0](v2.20.0...v2.21.0) (2021-11-03)

### Features

* manage multiple edge devices in PWA ([#757](#757)) ([72f72ba](72f72ba)), closes [#758](#758) [#753](#753) [#741](#741) [#711](#711) [#705](#705) [#660](#660) [#659](#659) [#601](#601) [#595](#595) [#589](#589) [#563](#563) [#408](#408) [#370](#370) [#329](#329) [#327](#327) [#302](#302) [#299](#299)
@ivelin
Copy link
Contributor

ivelin commented Nov 3, 2021

🎉 This issue has been resolved in version 2.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ivelin ivelin added the released label Nov 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@vickywane vickywane

Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: update/settings connection status vickywane/ambianic-ui
2 participants
@ivelin @vickywane