Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PWA background is not dynamically adaptable to daytime/nighttime theme changes #705

Closed
ivelin opened this issue Aug 16, 2021 · 2 comments
Closed

PWA background is not dynamically adaptable to daytime/nighttime theme changes #705

ivelin opened this issue Aug 16, 2021 · 2 comments
Labels
bug Something isn't working released wontfix This will not be worked on
Projects
Ambianic UI Agile Board

Comments

@ivelin
Copy link
Contributor

ivelin commented Aug 16, 2021

Describe the bug
The background of the PWA remains in a light color even when the rest of the components switch to dark theme when the underlying OS detects nighttime.

To Reproduce
Open the PWA while the OS is in dark mode.

Expected behavior
Background should adapt to dark theme when the OS changes the daylight setting automatically.

Screenshots
See screenshots.

Smartphone:

  • Device: iPhone6+
  • OS: Latest as of Aug 16, 2021
  • Browser: Safari

E213B687-3042-4003-A303-401B69D345A1
C2CFA1F5-08D9-462C-9FF5-50E882E49C7F
@ivelin ivelin added the bug Something isn't working label Aug 16, 2021
@ivelin ivelin added this to To do in Ambianic UI Agile Board via automation Aug 16, 2021
@stale
Copy link

stale bot commented Oct 30, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix This will not be worked on label Oct 30, 2021
@ivelin ivelin closed this as completed in 72f72ba Nov 3, 2021
Ambianic UI Agile Board automation moved this from To do to Done Nov 3, 2021
github-actions bot pushed a commit that referenced this issue Nov 3, 2021
@semantic-release-bot
chore(release): 2.21.0
d3bfe8e 
# [2.21.0](v2.20.0...v2.21.0) (2021-11-03)

### Features

* manage multiple edge devices in PWA ([#757](#757)) ([72f72ba](72f72ba)), closes [#758](#758) [#753](#753) [#741](#741) [#711](#711) [#705](#705) [#660](#660) [#659](#659) [#601](#601) [#595](#595) [#589](#589) [#563](#563) [#408](#408) [#370](#370) [#329](#329) [#327](#327) [#302](#302) [#299](#299)
@ivelin
Copy link
Contributor Author

ivelin commented Nov 3, 2021

🎉 This issue has been resolved in version 2.21.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ivelin ivelin added the released label Nov 3, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working released wontfix This will not be worked on
Projects
Ambianic UI Agile Board
  
Done
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ivelin