Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Boost Software License in ament_copyright package #207

Merged
merged 2 commits into from
Jan 31, 2020
Merged

Add support for Boost Software License in ament_copyright package #207

merged 2 commits into from
Jan 31, 2020

Conversation

Blast545
Copy link
Contributor

Adding support Boost Software License as stated in: LICENSE

Included test cases for .py and .cpp files.

@Blast545
Add support for the Boost Software License v1
bbc31ba 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545
Add tests for boost1 license
c1ab0a3 
Signed-off-by: Jorge J. Perez <jjperez@ekumenlabs.com>
@Blast545 Blast545 self-assigned this Jan 30, 2020
@Blast545 Blast545 added the enhancement New feature or request label Jan 30, 2020
jacobperron
jacobperron approved these changes Jan 31, 2020
View reviewed changes
Copy link
Contributor

@jacobperron jacobperron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

chapulina
chapulina approved these changes Jan 31, 2020
View reviewed changes
Copy link

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

While reviewing this, it was interesting to notice that Apache 2 is not being tested.

@jacobperron
Copy link
Contributor

While reviewing this, it was interesting to notice that Apache 2 is not being tested.

Addressed in #208

@Blast545
Copy link
Contributor Author

CI:

  • Linux Build Status
  • Linux-aarch64 Build Status
  • macOS Build Status
  • Windows Build Status

@Blast545 Blast545 merged commit 449f249 into master Jan 31, 2020
@delete-merged-branch delete-merged-branch bot deleted the blast545/ament_copyright_boost1 branch January 31, 2020 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chapulina chapulina chapulina approved these changes

@jacobperron jacobperron jacobperron approved these changes

Assignees

@Blast545 Blast545

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Blast545 @jacobperron @chapulina