[ament_cppcheck] Report errors from additional includes #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before, if an error was found in an additional include we get a KeyError exception. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
|
CI including ros2/rclcpp#1000
|
dirk-thomas
reviewed
Feb 26, 2020
Signed-off-by: Jacob Perron <jacob@openrobotics.org>
dirk-thomas
approved these changes
Mar 3, 2020
delete-merged-branch
bot
deleted the
jacob/cppcheck_report_additional_includes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, if an error was found in an additional include we get a KeyError exception.
For example: https://ci.ros2.org/job/ci_linux/9443/testReport/junit/(root)/rclcpp_action/cppcheck_xunit_missing_result/
Additional includes added to rclcpp_action and rclcpp_lifecycle in ros2/rclcpp#1000 by chance picked up a cppcheck error in rclcpp, causing a KeyError exception.
The other option is to ignore errors from additional include directories, but I think being louder about errors is better.