Fix unknown macro errors reported by cppcheck 1.90 #1000
Conversation
|
Example failure from our nightly build on Focal: http://build.ros2.org/view/Fci/job/Fci__nightly-fastrtps_ubuntu_focal_amd64/38/testReport/ |
|
|
CI is running into Python exceptions coming from ament_cppcheck (but only on Linux builds). I didn't run into these locally 🤔 Edit: okay, I can repro. Looking into it. |
|
There is a bug in ament_cppcheck. See ament/ament_lint#216 for a fix. |
|
I don't know why cppcheck is happy on Windows and macOS... I guess it must simply be a difference in versions. |
|
Fixed a cppcheck error in rclcpp (222f3b8). I don't know why the error is not reported when testing rclcpp. It only shows up transitively in rclcpp_action and rclcpp_lifecycle. |
|
macOS: |
jacobperron
force-pushed
the
jacob/cppcheck_macro_errors
branch
from
4bc8039
to
ca1af29
Compare
|
I've cleaned up the commits:
|
|
The second commit doesn't match the PR title. Either split or update the PR title. |
|
Split second commit out in #1011 |
This PR has still both commits. |
|
I'll rebase this once the other has merged, since CI depends on it. |
It was complaining about an unknown macro RCLCPP_SMART_PTR_DEFINITIONS. Passing rclcpp include directories to cppcheck resolves the errors reported in rclcpp_action and rclcpp_lifecycle. Signed-off-by: Jacob Perron <jacob@openrobotics.org>
jacobperron
force-pushed
the
jacob/cppcheck_macro_errors
branch
from
ca1af29
to
244ea20
Compare
|
@dirk-thomas rebased. |
|
This pull request has been mentioned on ROS Discourse. There might be relevant details there: |
It was complaining about an unknown macro RCLCPP_SMART_PTR_DEFINITIONS.
Passing rclcpp include directories to cppcheck resolves the errors
reported in rclcpp_action and rclcpp_lifecycle.