Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[humble] Consider files with '.hh' extension as C++ headers (#374) #378

Merged
merged 1 commit into from
May 9, 2022
Merged

[humble] Consider files with '.hh' extension as C++ headers (#374) #378

merged 1 commit into from
May 9, 2022

Conversation

jacobperron
Copy link
Contributor

@jacobperron jacobperron commented May 5, 2022 •
edited
Loading

Backport #374 to Humble.

Connects to ros2/rviz#859

@jacobperron
Consider files with '.hh' extension as C++ headers (#374)
1489786 
Without this change, these files are considered to be C system headers.
This change affects the expected include order with respect to '.hh' files.

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron mentioned this pull request May 5, 2022
Merged
@jacobperron jacobperron changed the title Consider files with '.hh' extension as C++ headers (#374) [humble] Consider files with '.hh' extension as C++ headers (#374) May 5, 2022
@jacobperron
Copy link
Contributor Author

jacobperron commented May 6, 2022 •
edited
Loading

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit 87f3133 into master May 9, 2022
@delete-merged-branch delete-merged-branch bot deleted the jacob/humble_backport_374 branch May 9, 2022 21:02
@jacobperron jacobperron mentioned this pull request May 9, 2022
Merged
@jacobperron
Copy link
Contributor Author

I merged this to master instead of humble 🙃 See #381

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clalancette clalancette clalancette approved these changes

@audrow audrow audrow approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jacobperron @clalancette @audrow