Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[humble] Fix include order (#858) #859

Merged
merged 1 commit into from
May 9, 2022
Merged

Conversation

jacobperron
Copy link
Member

Backport #858 to Humble

Depends on ament/ament_lint#378

Related to ament/ament_lint#374

Signed-off-by: Jacob Perron <jacob@openrobotics.org>
@jacobperron jacobperron changed the title Fix include order (#858) [humble] Fix include order (#858) May 5, 2022
@jacobperron jacobperron added this to In progress in Humble Hawksbill via automation May 5, 2022
@jacobperron jacobperron moved this from In progress to In review in Humble Hawksbill May 5, 2022
Copy link
Contributor

@clalancette clalancette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Rpr is going to fail until we merge and release ament/ament_lint#378 . So we'll just rely on green CI here.

@jacobperron
Copy link
Member Author

jacobperron commented May 6, 2022

  • Linux Build Status
  • Linux-aarch64 Build Status
  • Windows Build Status

@jacobperron jacobperron merged commit d64a38a into humble May 9, 2022
Humble Hawksbill automation moved this from In review to Done May 9, 2022
@jacobperron jacobperron deleted the jacob/humble_backport_858 branch May 9, 2022 21:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants