[WIP] Split up lib.rs into files #14
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently I was able to crate this branch directly. What do you prefer? Do you want me to fork this library or is this oke?
Don't worry about the LoC change count. This has to do with moving files around. You can skip all the added files. And the removed code in lib.rs.
Currently. For all the files and test I get the error:
This has probably something to do with the proc macro. I am looking into this.
Changes
Fixes: #13
I moved the re-exports like this:
The usings in public export are used in
serde-diff-derive
crate. Previously all types were exported. But hidden for documentation. This PR only exposes the nessicarly types and hides the others. By doing this we introduce API breaking changes. Though the impact will be minimal because they were hidden for the documentation and we get better encapsulation. We do need to do a major patch.