Skip to content

Conversation

AnandajithS
Copy link
Contributor

  • Added github_username: String to the Member struct
  • Updated the references and usage of Member model to accommodate the new field

Closes #150

@hrideshmg
Copy link
Member

Hi, thanks for the PR. Just a couple of things to fix before we can merge it:

  • Since we’re adding a new database column, you’ll need to create a new migration using sqlx to insert the column.
  • Please also update /src/database_seeder/seed.sql so our development data stays in sync with the latest schema.

Before opening the PR next time, it’d be great if you test your changes that would help catch issues like these early. Also, don’t forget to run rustfmt before committing (looks like the formatting check is currently failing).

@hrideshmg hrideshmg requested a review from Copilot October 13, 2025 07:11
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds GitHub username support to the Member model by introducing a new github_user field. The changes ensure the new field is properly integrated across the data layer, GraphQL API, and database seeding.

  • Added github_user: String field to Member struct and related input types
  • Updated database queries to include the new field in INSERT and UPDATE operations
  • Added database migration and updated seed data to include GitHub usernames

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
src/models/member.rs Added github_user field to Member, CreateMemberInput, and UpdateMemberInput structs
src/graphql/mutations/member_mutations.rs Updated SQL queries and parameter bindings to handle the new github_user field
src/database_seeder/seed.sql Modified seed data to include github_user values for test data
migrations/20251011162144_add_github_user.sql Added database migration to create the github_user column

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@hrideshmg
Copy link
Member

LGTM! Thanks for fixing the track value in the seeder as well.

@hrideshmg hrideshmg merged commit dc65e0a into amfoss:develop Oct 13, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add github username field to member object

2 participants