-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hardware parameters #31
Add hardware parameters #31
Conversation
@Giulero @traversaro I am having a few issues in fixing the error with NumPy and the computation of the CoM, has can be seen in the CI
So it seems like Anyhow I saw that, when cast to Side note: I saw that the problem does not lay in the implementation of https://github.com/ami-iit/ADAM/blob/5d50695e0ed839552ec9143764e8a985a3510c13/src/adam/numpy/numpy_like.py#L50, the program does not enter in the function. In addition, we have the same old problem that I would need the stickbot for running the test with hardware parameters online, @traversaro If I do not recall wrong there should be someway to load that urdf here in a smart way, Am I correct ? Thanks :) |
Sorry, I do not recall what the "same old problem" is :) |
See https://github.com/ami-iit/ADAM/pull/31/files#r1050528666 . |
I would need to load here the stickbot model https://github.com/icub-tech-iit/ergocub-gazebo-simulations/tree/master/models/stickBot or any urdf with simple shapes but without including it in the repo, something similar to this |
If the model is available and does not have meshes (that are the tricky part when dealing with URDF files), we can easily either:
If the file is not big, option 1. is not bad, as it make sure that the tests work fine even if there is no internet or for some reason the remote resource is not available (the server is offline, permanently down or the content itself has been removed). |
a038392
to
1c2b0a2
Compare
The PR is ready for review !
Few assumptions:
Note that the C.C. @Giulero @traversaro @lrapetti |
…joint parameteric, refactoring
cff2945
to
6ff689d
Compare
rebased on top of #34 |
Changed class names to follow the repo convention with ce6c270 |
No description provided.