Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split deps #21

Merged
merged 11 commits into from
May 17, 2022
Merged

Split deps #21

merged 11 commits into from
May 17, 2022

Conversation

Giulero
Copy link
Collaborator

@Giulero Giulero commented May 17, 2022

I want to update the installation procedure for pruning dependencies that the user might not need in this PR.
For example, the installation would require PyTorch even if the user just needs the CasAdi interface.

Now the installation would need:

  • jax interface:

    pip install .[jax]
  • casadi interface:

    pip install .[casadi]
  • pytorch interface:

    pip install .[pytorch]

or, if the user does not want to clone the repo:

pip install adam[selected-interface]@git+https://github.com/ami-iit/ADAM

I took also the occasion to change the import syntax.
Before:

from adam.casadi.computations import KinDynComputations

After:

from adam.casadi import KinDynComputations

The import syntax used before is still working, so the old code using adam does not need to be updated.

@Giulero Giulero requested a review from traversaro May 17, 2022 13:16
@Giulero Giulero self-assigned this May 17, 2022

### Installation with apt
The installation can be done either using the Python provided by apt (on Linux) or via conda (on Linux and macOS).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit confusing to have the sentence mentioning conda in a section that is not related to conda, but rather to the use of pip + apt .

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! A bad copy-paste :/

@traversaro
Copy link
Contributor

Given that the version that is currently in master (i.e. after #20) has been the default one installed if somebody cloned the repo in the last two months, could it make sense to tag it as 0.0.2 and then merge this PR?

@Giulero
Copy link
Collaborator Author

Giulero commented May 17, 2022

Given that the version that is currently in master (i.e. after #20) has been the default one installed if somebody cloned the repo in the last two months, could it make sense to tag it as 0.0.2 and then merge this PR?

Sure! I'll update also 5c54e46.

@Giulero Giulero merged commit 438eff8 into main May 17, 2022
@Giulero Giulero deleted the split-deps branch May 17, 2022 13:48
@Giulero
Copy link
Collaborator Author

Giulero commented May 17, 2022

Thanks @traversaro! Merging.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants