-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Split deps #21
Split deps #21
Conversation
|
||
### Installation with apt | ||
The installation can be done either using the Python provided by apt (on Linux) or via conda (on Linux and macOS). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is a bit confusing to have the sentence mentioning conda in a section that is not related to conda, but rather to the use of pip + apt .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! A bad copy-paste :/
Given that the version that is currently in master (i.e. after #20) has been the default one installed if somebody cloned the repo in the last two months, could it make sense to tag it as 0.0.2 and then merge this PR? |
Thanks @traversaro! Merging. |
I want to update the installation procedure for pruning dependencies that the user might not need in this PR.
For example, the installation would require
PyTorch
even if the user just needs theCasAdi
interface.Now the installation would need:
jax interface:
casadi interface:
pytorch interface:
or, if the user does not want to clone the repo:
I took also the occasion to change the import syntax.
Before:
After:
The import syntax used before is still working, so the old code using adam does not need to be updated.