Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add prismatic joints #29

Merged
merged 6 commits into from
Oct 5, 2022
Merged

Add prismatic joints #29

merged 6 commits into from
Oct 5, 2022

Conversation

Giulero
Copy link
Collaborator

@Giulero Giulero commented Oct 3, 2022

This PR adds prismatic joints manipulations. Basically I copy-pasted the modification @CarlottaSartore did in a previous pr.

Since we now support 3 different types of joint it might be worth to generalize the joint interface, since the code contains some duplicates. I'll do it (maybe in a separate PR).

I need a urdf of a robot with prismatic joints to test the modifications.

Fixes #28

@Giulero Giulero self-assigned this Oct 3, 2022
@traversaro
Copy link
Contributor

I need a urdf of a robot with prismatic joints to test the modifications.

Probably the easiest thing to do is to start with a trivial one, like https://github.com/robotology/idyntree/blob/master/src/tests/data/twoLinks.urdf but substituting the continuous joint with a prismatic one.

@Giulero
Copy link
Collaborator Author

Giulero commented Oct 5, 2022

Tested with an urdf with prismatic joints! Tests successful

Copy link
Collaborator

@CarlottaSartore CarlottaSartore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me !

@traversaro
Copy link
Contributor

cc @VenusPasandi

@Giulero Giulero merged commit 5d50695 into main Oct 5, 2022
@Giulero Giulero deleted the add-prismatic-joints branch October 5, 2022 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support prismatic joints
3 participants