Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link filtering #85

Merged
merged 8 commits into from
Jun 12, 2024
Merged

Fix link filtering #85

merged 8 commits into from
Jun 12, 2024

Conversation

Giulero
Copy link
Collaborator

@Giulero Giulero commented Jun 12, 2024

This PR fixes #82.
The link filtering was done by selecting the links with inertia (and frames without inertia; see #83 (comment)).

With this fix, massless links with children are also considered connecting links, and the tree is not broken.

@Giulero Giulero mentioned this pull request Jun 12, 2024
@Giulero
Copy link
Collaborator Author

Giulero commented Jun 12, 2024

The parametric interface is failing. I'm gonna fix it

@Giulero
Copy link
Collaborator Author

Giulero commented Jun 12, 2024

Parametric interface fixed. I've also added the additional check #83 (comment)

Namely, citing idyntree:

/**
 * The condition for a link to be classified as "fake link" are:
 *  * The link has a zero mass.
 *  * The link is a leaf, i.e. it is connected to only one neighbor.
 *  * The link is connected to its only neighbor with a fixed joint.
 */

@Giulero
Copy link
Collaborator Author

Giulero commented Jun 12, 2024

Thanks guys! :) Merging.

@Giulero Giulero merged commit 2b33c5f into main Jun 12, 2024
15 checks passed
@Giulero Giulero deleted the fix-link-filtering branch June 12, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error detecting two root links
3 participants