Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support of parametric hardware models #101

Merged
merged 18 commits into from
Mar 14, 2024

Conversation

diegoferigo
Copy link
Member

@diegoferigo diegoferigo commented Mar 6, 2024

Currently, JaxSim builds three models from a model description (URDF, SDF):

One of the objective of the new functional APIs (#108) is to expose a set of hardware parameters so that downstream projects can compute their gradient by exploiting automatic differentiation.

This PR introduces the initial support towards this goal. Particularly:

  • Introduces a new KinDynParameters class, stored inside JaxSimModel, that will soon replace PhysicsModel. Its aim is to act as a simple container of joint, link, and contact parameters, with useful setters for updating them without re-creating from scratch a new JaxSimModel object.
  • Starts the transition from PhysicsModel to JaxSimModel (will be finalized in #112).

📚 Documentation preview 📚: https://jaxsim--101.org.readthedocs.build//101/

@diegoferigo diegoferigo self-assigned this Mar 6, 2024
@S-Dafarra
Copy link
Member

cc @CarlottaSartore

@diegoferigo diegoferigo force-pushed the feature/kin_dyn_parameters branch 2 times, most recently from 8952c1b to 9044c86 Compare March 8, 2024 15:16
@diegoferigo diegoferigo force-pushed the feature/kin_dyn_parameters branch 6 times, most recently from 602a0d3 to ed0cd77 Compare March 12, 2024 10:04
@diegoferigo diegoferigo force-pushed the feature/kin_dyn_parameters branch 3 times, most recently from 81c8246 to 6f570bb Compare March 12, 2024 16:01
@diegoferigo diegoferigo changed the base branch from main to functional March 12, 2024 16:01
@diegoferigo diegoferigo force-pushed the feature/kin_dyn_parameters branch 4 times, most recently from 35df971 to 9568eb7 Compare March 14, 2024 10:51
@diegoferigo diegoferigo marked this pull request as ready for review March 14, 2024 13:13
Copy link
Collaborator

@flferretti flferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Diego, LGTM! I just wrote some minor comments

src/jaxsim/api/kin_dyn_parameters.py Outdated Show resolved Hide resolved
src/jaxsim/api/kin_dyn_parameters.py Outdated Show resolved Hide resolved
src/jaxsim/api/kin_dyn_parameters.py Outdated Show resolved Hide resolved
src/jaxsim/api/kin_dyn_parameters.py Outdated Show resolved Hide resolved
src/jaxsim/api/link.py Outdated Show resolved Hide resolved
src/jaxsim/api/joint.py Outdated Show resolved Hide resolved
src/jaxsim/api/ode.py Show resolved Hide resolved
src/jaxsim/api/ode.py Outdated Show resolved Hide resolved
src/jaxsim/physics/algos/soft_contacts.py Outdated Show resolved Hide resolved
@diegoferigo diegoferigo force-pushed the feature/kin_dyn_parameters branch 2 times, most recently from 61dd60d to 1c00e1e Compare March 14, 2024 15:37
Co-authored-by: Filippo Luca Ferretti <102977828+flferretti@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants