Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance parametric hardware models #120

Merged
merged 9 commits into from
Mar 27, 2024
Merged

Conversation

diegoferigo
Copy link
Member

@diegoferigo diegoferigo commented Mar 26, 2024

  • Fix bugs and copy-paste errors.
  • Store indices inside {Link|Joint}Parameters classes.
  • Add docstring and comments.

Follows up #101.


📚 Documentation preview 📚: https://jaxsim--120.org.readthedocs.build//120/

@diegoferigo diegoferigo self-assigned this Mar 26, 2024
@diegoferigo diegoferigo changed the base branch from main to functional March 26, 2024 14:49
@diegoferigo diegoferigo changed the title Enhance parametric hardwre models Enhance parametric hardware models Mar 26, 2024
@diegoferigo diegoferigo force-pushed the enhance_parametric_models branch 3 times, most recently from 9b7e7f1 to b460a36 Compare March 26, 2024 15:36
@diegoferigo diegoferigo marked this pull request as ready for review March 27, 2024 09:46
Copy link
Collaborator

@flferretti flferretti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@diegoferigo diegoferigo merged commit 43a4aed into functional Mar 27, 2024
21 checks passed
@diegoferigo diegoferigo deleted the enhance_parametric_models branch March 27, 2024 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants