Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow backward compatibility with Python 3.10 #143

Merged
merged 4 commits into from
Apr 23, 2024
Merged

Conversation

flferretti
Copy link
Collaborator

@flferretti flferretti commented Apr 23, 2024

Fixes #141

@diegoferigo should we also add a CI for Python 3.10 or do we want to keep it "unofficial"?


馃摎 Documentation preview 馃摎: https://jaxsim--143.org.readthedocs.build//143/

@diegoferigo
Copy link
Member

If we have use cases where Python 3.11 is not installed and we cannot upgrade (like remote machines / colab / etc), I'm in favor of supporting officially Python 3.10.

should we also add a CI for Python 3.10 or do we want to keep it "unofficial"?

Considering that there are not big changes between 3.10 and 3.11 (just Self in our code base), adding back the support should be straightforward. Regardless, to prevent to overlook things, I would also enable 3.10 in CI. In any case it would run concurrently with the other Python versions.

We can consider to remove Python 3.10 support in the future. For the time being, supporting for a while more ubuntu 22.04 makes sense to me.

@traversaro
Copy link
Contributor

If we have use cases where Python 3.11 is not installed and we cannot upgrade (like remote machines / colab / etc), I'm in favor of supporting officially Python 3.10.

Yes, I guess the use case is mainly that, see #141 .

@flferretti flferretti merged commit 98055c3 into main Apr 23, 2024
29 checks passed
@flferretti flferretti deleted the flferretti-patch-3 branch April 23, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot run notebook examples on Colab
3 participants