Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove whole-body-controllers as dependency of this repo #46

Closed
nunoguedelha opened this issue May 10, 2021 · 1 comment · Fixed by #49
Closed

Remove whole-body-controllers as dependency of this repo #46

nunoguedelha opened this issue May 10, 2021 · 1 comment · Fixed by #49
Assignees
@nunoguedelha
Labels
enhancement New feature or request

Comments

@nunoguedelha
Copy link
Collaborator

matlab-whole-body-simulator has become a dependency of whole-body-controllers since robotology/whole-body-controllers#122. For avoiding loop dependencies we should remove whole-body-controllers dependency from this repo. It's already the case when matlab-whole-body-simulator is installed through the superbuild, but the dependency is still present in the installation through Conda and in the documentation. All these left overs should be cleaned. The actual functional dependency (usage of +wbc.skew() can be easily removed.
@nunoguedelha nunoguedelha added the enhancement New feature or request label May 10, 2021
@nunoguedelha nunoguedelha self-assigned this May 10, 2021
@nunoguedelha
Copy link
Collaborator Author

CC @traversaro

@nunoguedelha nunoguedelha mentioned this issue May 14, 2021
Merged
@nunoguedelha nunoguedelha linked a pull request May 14, 2021 that will close this issue
Remove dependency from whole-body-controllers #49
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nunoguedelha nunoguedelha

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove dependency from whole-body-controllers ami-iit/matlab-whole-body-simulator
2 participants
@traversaro @nunoguedelha