Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: signals to be logged #121

Closed
9 tasks done
S-Dafarra opened this issue Jul 11, 2022 · 8 comments
Closed
9 tasks done

Feature request: signals to be logged #121

S-Dafarra opened this issue Jul 11, 2022 · 8 comments
Assignees
Labels
Epic feature Feature request

Comments

@S-Dafarra
Copy link
Member

S-Dafarra commented Jul 11, 2022

In order to improve the usability of the framework, I think it would be important to add this set of data to be logged:

This is the list of things we are currently logging for offline testing. Reference code: https://github.com/ami-iit/bipedal-locomotion-framework/tree/dc113093d2467e854a2b1427265af55f559f13d0/devices/YarpRobotLoggerDevice

Let me remark that this data might be robot-dependent. For example, the lists of FTs and cartesian_wrenches depend on the robot.

Moreover, we might need to add more data in the future.

cc @nunoguedelha @traversaro

@S-Dafarra
Copy link
Member Author

It might also be useful to log the text log coming from the modules. In general anyway, it would be nice to have a shared interface between the online and offline logging.

cc @GiulioRomualdi

@GiulioRomualdi
Copy link
Member

For the TextLogging I took inspiration from what is done in YarpManager. ami-iit/bipedal-locomotion-framework#546

@nunoguedelha nunoguedelha self-assigned this Jul 22, 2022
@nunoguedelha nunoguedelha added Epic feature Feature request labels Jul 22, 2022
@nunoguedelha
Copy link
Collaborator

For the TextLogging I took inspiration from what is done in YarpManager. ami-iit/bipedal-locomotion-framework#546

@GiulioRomualdi , I guess you meant more specifically ami-iit/bipedal-locomotion-framework#541.

@nunoguedelha
Copy link
Collaborator

nunoguedelha commented Sep 2, 2022

@S-Dafarra , I've added the following bullets/issues in the description according to your comments:

  • Improve the handling of the robot dependant configuration
  • Add the possibility to log the YarpTextLogging

@nunoguedelha
Copy link
Collaborator

@S-Dafarra , I had already added #133 to this epic, and just added it to the issue description.

Also added the issue #139 fixing the problems we ran into during the last test session on Friday.

@nunoguedelha
Copy link
Collaborator

Since #137 is in Backlog and not the top priority right now, I'm moving it out of the Epic for being able to close it.

@nunoguedelha
Copy link
Collaborator

If it's ok with you @S-Dafarra , I would close this Epic.

@S-Dafarra
Copy link
Member Author

I agree. Great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Epic feature Feature request
Projects
None yet
Development

No branches or pull requests

3 participants