Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problematic apostrophe. #1345

Closed
1 of 2 tasks
cm-slu opened this issue Nov 8, 2022 · 4 comments
Closed
1 of 2 tasks

Problematic apostrophe. #1345

cm-slu opened this issue Nov 8, 2022 · 4 comments
Labels
bug Something isn't working

Comments

@cm-slu
Copy link

cm-slu commented Nov 8, 2022

Server Info (please complete the following information):

  • OS: [Ubuntu 20.04]
  • Browser: [chrome]
  • RMM Version : Latest

Installation Method:

  • Standard
  • Docker

Agent Info (please complete the following information):

  • Agent version (as shown in the 'Summary' tab of the agent from web UI):2.4.1
  • Agent OS: [e.g. Win 10 v2004, Server 2012 R2]: All Windows

Describe the bug
The terminator ' is missing from the string.
+ CategoryInfo : ParserError: (:) [], ParentContainsErrorRecordEx
ception
+ FullyQualifiedErrorId : TerminatorExpectedAtEndOfString

To Reproduce
Steps to reproduce the behavior:

  1. In description of agent add apostrophe ( ' )
  2. In script add an argument agent.description

Screenshots
image

@wh1te909 wh1te909 added the bug Something isn't working label Nov 8, 2022
@silversword411
Copy link
Collaborator

Should there be a test in the repo for testing chars in fields?

Should probably have input validation everywhere for all chars...like null space chars and all the other weird chars

@wh1te909
Copy link
Member

@cm-slu I have pushed a fix please see the linked commit and manually make the change on your server and then sudo systemctl restart rmm and please test it out and let me know if it works

@silversword411 a unit test would not catch it, need an end to end test to run on a real agent

wh1te909 added a commit that referenced this issue Dec 24, 2022
@cm-slu
Copy link
Author

cm-slu commented Jan 9, 2023

Hello, and thank you very much for the correction.

I prefer to wait for the release, I'm not sure I know how to patch the version.

@wh1te909
Copy link
Member

@cm-slu it's released now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants