Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update agent_linux.sh #1796

Closed
wants to merge 5 commits into from
Closed

Conversation

dinger1986
Copy link
Collaborator

for usage like this ./install_script.sh --binpath /my/custom/path

to close this issue #1508

Copy link

codecov bot commented Mar 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.20%. Comparing base (6586510) to head (566ce0d).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1796      +/-   ##
===========================================
- Coverage    79.31%   79.20%   -0.12%     
===========================================
  Files          138      138              
  Lines         9645     9661      +16     
===========================================
+ Hits          7650     7652       +2     
- Misses        1995     2009      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wh1te909
Copy link
Member

doesn't work, i tested like this ./agent.sh --binpath /opt/trmmtest and still installed to /usr/local/bin

@dinger1986
Copy link
Collaborator Author

I'll check it and sort it

@dinger1986
Copy link
Collaborator Author

dinger1986 commented Mar 14, 2024

sorted, hadnt copied up $2 for some reason sorry! for the line CUSTOM_BIN_PATH="", also moved that next to the others

image

@wh1te909
Copy link
Member

thanks now just uninstall doesn't cleanup properly, binary is still left behind.

@dinger1986
Copy link
Collaborator Author

its actually not right anyway, what I have done is basically accept the second argument when running the script as the binpath and thats not right, let me look at it a bit more

@dinger1986
Copy link
Collaborator Author

reordered alot of parts and added command to find bin location from service file, tested working on debian 11 and 12

@dinger1986 dinger1986 closed this by deleting the head repository Mar 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants