Skip to content

Conversation

amihaiemil
Copy link
Owner

PR for #128

Added and unit tested Container.logs() and left puzzle to continue

@0crat
Copy link
Collaborator

0crat commented Jun 4, 2018

Job #129 is now in scope, role is REV

@coveralls
Copy link

coveralls commented Jun 4, 2018

Pull Request Test Coverage Report for Build 242

  • 6 of 8 (75.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 81.907%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/amihaiemil/docker/RtLogs.java 5 7 71.43%
Totals Coverage Status
Change from base Build 240: -0.1%
Covered Lines: 335
Relevant Lines: 409

💛 - Coveralls

@0crat
Copy link
Collaborator

0crat commented Jun 4, 2018

This pull request #129 is assigned to @llorllale/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@llorllale
Copy link
Contributor

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jun 5, 2018

@rultor merge

@llorllale Thanks for your request. @amihaiemil Please confirm this.

@amihaiemil
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Jun 6, 2018

@rultor merge

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 00dabcc into master Jun 6, 2018
@rultor
Copy link
Collaborator

rultor commented Jun 6, 2018

@rultor merge

@amihaiemil Done! FYI, the full log is here (took me 3min)

@amihaiemil amihaiemil deleted the 128 branch June 6, 2018 04:43
@0crat
Copy link
Collaborator

0crat commented Jun 6, 2018

Order was finished: +15 point(s) just awarded to @llorllale/z

@0crat
Copy link
Collaborator

0crat commented Jun 6, 2018

The job #129 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Jun 6, 2018

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @amihaiemil/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants