Skip to content

Conversation

llorllale
Copy link
Contributor

This PR:

@coveralls
Copy link

coveralls commented May 8, 2018

Pull Request Test Coverage Report for Build 154

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 83.784%

Totals Coverage Status
Change from base Build 152: 0.6%
Covered Lines: 248
Relevant Lines: 296

💛 - Coveralls

@0crat
Copy link
Collaborator

0crat commented May 8, 2018

Job #101 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented May 8, 2018

@amihaiemil/z everybody who has role REV are banned at this job; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

Copy link
Owner

@amihaiemil amihaiemil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llorllale one comment about parents. I think that part should be removed, as it doesn't seem correct, and delete() should be void.

/**
* The enclosing {@link Images} for this image.
*/
private final Images parent;
Copy link
Owner

@amihaiemil amihaiemil May 9, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llorllale I don't think this is correct. "parent Images" does not refer to the Images instance which created this Image, but to those Images that are parents in terms of Docker history, previous versions, "layers", of this Image, see the history operation. Makes sense?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amihaiemil I see what you mean by "parent images"; I was just going for a "fluent" interface. I'll make it void then.

As per PR review:
* Made Image.delete() return void
@llorllale
Copy link
Contributor Author

@amihaiemil made Image.delete() return void, please check

@amihaiemil
Copy link
Owner

@llorllale nice, thanks :)

@amihaiemil
Copy link
Owner

@rultor merge it

@rultor
Copy link
Collaborator

rultor commented May 10, 2018

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented May 10, 2018

@rultor merge it

@amihaiemil @llorllale Oops, I failed. You can see the full log here (spent 20s)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 5014
+ echo '1.67.2 b60448e97'
1.67.2 b60448e97
+ date
Thu May 10 15:31:08 CEST 2018
+ uptime
 15:31:08 up 46 days, 19:03,  0 users,  load average: 0.08, 0.05, 0.15
+ ff=default
+ image=yegor256/java8
+ rebase=false
+ head_branch=master
./run.sh: line 23: syntax error near unexpected token `('
'cid' file is absent, container wasn't started correctly

@amihaiemil amihaiemil merged commit d253105 into amihaiemil:master May 10, 2018
@0crat
Copy link
Collaborator

0crat commented May 10, 2018

The job #101 is now out of scope

@llorllale llorllale deleted the 96 branch May 10, 2018 20:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants