-
-
Notifications
You must be signed in to change notification settings - Fork 55
(#96) Implemented Image.delete() #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 154
💛 - Coveralls |
Job #101 is now in scope, role is |
@amihaiemil/z everybody who has role |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llorllale one comment about parents. I think that part should be removed, as it doesn't seem correct, and delete()
should be void.
/** | ||
* The enclosing {@link Images} for this image. | ||
*/ | ||
private final Images parent; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llorllale I don't think this is correct. "parent Images" does not refer to the Images
instance which created this Image, but to those Images
that are parents in terms of Docker history, previous versions, "layers", of this Image
, see the history
operation. Makes sense?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amihaiemil I see what you mean by "parent images"; I was just going for a "fluent" interface. I'll make it void
then.
As per PR review: * Made Image.delete() return void
@amihaiemil made |
@llorllale nice, thanks :) |
@rultor merge it |
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
@amihaiemil @llorllale Oops, I failed. You can see the full log here (spent 20s)
|
The job #101 is now out of scope |
This PR: