Skip to content

Conversation

amihaiemil
Copy link
Owner

PR for #93
Left puzzle for using this handler to reduce code duplication.

@0crat
Copy link
Collaborator

0crat commented May 10, 2018

Job #104 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented May 10, 2018

This pull request #104 is assigned to @llorllale/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer

@coveralls
Copy link

Pull Request Test Coverage Report for Build 160

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 84.262%

Totals Coverage Status
Change from base Build 158: 0.5%
Covered Lines: 257
Relevant Lines: 305

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 160

  • 9 of 9 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 84.262%

Totals Coverage Status
Change from base Build 158: 0.5%
Covered Lines: 257
Relevant Lines: 305

💛 - Coveralls

@llorllale
Copy link
Contributor

@rultor good to merge

@rultor
Copy link
Collaborator

rultor commented May 10, 2018

@rultor good to merge

@llorllale Thanks for your request. @amihaiemil Please confirm this.

@amihaiemil
Copy link
Owner Author

@rultor merge

@rultor
Copy link
Collaborator

rultor commented May 11, 2018

@rultor merge

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 4e08d97 into master May 11, 2018
@amihaiemil amihaiemil deleted the 93 branch May 11, 2018 06:43
@rultor
Copy link
Collaborator

rultor commented May 11, 2018

@rultor merge

@amihaiemil Done! FYI, the full log is here (took me 3min)

@0crat
Copy link
Collaborator

0crat commented May 11, 2018

Order was finished: +15 point(s) just awarded to @llorllale/z

@0crat
Copy link
Collaborator

0crat commented May 11, 2018

The job #104 is now out of scope

@0crat
Copy link
Collaborator

0crat commented May 11, 2018

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @amihaiemil/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants