Skip to content

Conversation

amihaiemil
Copy link
Owner

PR for #58
Started writing Integration tests

@0crat
Copy link
Collaborator

0crat commented May 15, 2018

Job #107 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented May 15, 2018

This pull request #107 is assigned to @llorllale/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer

@llorllale
Copy link
Contributor

@amihaiemil build is failing

@coveralls
Copy link

Pull Request Test Coverage Report for Build 172

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 84.877%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/amihaiemil/docker/Inspection.java 0 1 0.0%
Totals Coverage Status
Change from base Build 166: -0.3%
Covered Lines: 275
Relevant Lines: 324

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 172

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.3%) to 84.877%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/amihaiemil/docker/Inspection.java 0 1 0.0%
Totals Coverage Status
Change from base Build 166: -0.3%
Covered Lines: 275
Relevant Lines: 324

💛 - Coveralls

@amihaiemil
Copy link
Owner Author

@llorllale It works now. The problem was that the hello-world image was not present (I added docker pull hello-world to .travis.yml, so we always have at least that image.

@amihaiemil
Copy link
Owner Author

@llorllale I'll merge it, because I want to show the unit test in a ticket for docker on Github. It has a strange behaviour: it responds with 404 when the container cannot be created (because the image is missing), instead of 412...

@amihaiemil amihaiemil merged commit 8d2bd06 into master May 15, 2018
@amihaiemil amihaiemil deleted the 58 branch May 15, 2018 18:01
@0crat
Copy link
Collaborator

0crat commented May 15, 2018

Order was finished: +15 point(s) just awarded to @llorllale/z

@0crat
Copy link
Collaborator

0crat commented May 15, 2018

The job #107 is now out of scope

@0crat
Copy link
Collaborator

0crat commented May 15, 2018

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @amihaiemil/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants