Skip to content

Conversation

llorllale
Copy link
Contributor

This PR:

@0crat
Copy link
Collaborator

0crat commented May 16, 2018

Job #112 is now in scope, role is REV

@coveralls
Copy link

Pull Request Test Coverage Report for Build 176

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 85.329%

Totals Coverage Status
Change from base Build 173: 0.5%
Covered Lines: 285
Relevant Lines: 334

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 176

  • 10 of 10 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 85.329%

Totals Coverage Status
Change from base Build 173: 0.5%
Covered Lines: 285
Relevant Lines: 334

💛 - Coveralls

@0crat
Copy link
Collaborator

0crat commented May 16, 2018

@amihaiemil/z everybody who has role REV are banned at #112; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@amihaiemil amihaiemil self-assigned this May 16, 2018
@amihaiemil
Copy link
Owner

@llorllale looks nice

@amihaiemil
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented May 16, 2018

@rultor merge

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor
Copy link
Collaborator

rultor commented May 16, 2018

@rultor merge

@amihaiemil @llorllale Oops, I failed. You can see the full log here (spent 20s)

+ set -e
+ set -o pipefail
++ dirname ./run.sh
+ cd .
+ echo 378
+ echo '1.67.3 ae5cf34be'
1.67.3 ae5cf34be
+ date
Wed May 16 21:40:56 CEST 2018
+ uptime
 21:40:56 up 1 day, 13:14,  0 users,  load average: 0.76, 0.74, 0.71
+ ff=default
+ image=yegor256/java8
+ rebase=false
+ head_branch=master
./run.sh: line 23: syntax error near unexpected token `('
'cid' file is absent, container wasn't started correctly

@0crat
Copy link
Collaborator

0crat commented May 16, 2018

This pull request #112 is assigned to @amihaiemil/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer

@0crat
Copy link
Collaborator

0crat commented May 16, 2018

Manual assignment of issues is discouraged, see §19: -5 point(s) just awarded to @amihaiemil/z

@amihaiemil amihaiemil merged commit 2fad752 into amihaiemil:master May 16, 2018
@0crat
Copy link
Collaborator

0crat commented May 16, 2018

Order was finished: +15 point(s) just awarded to @amihaiemil/z

@0crat
Copy link
Collaborator

0crat commented May 16, 2018

The job #112 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants