Skip to content

Conversation

amihaiemil
Copy link
Owner

Pr for #135

@0crat
Copy link
Collaborator

0crat commented Jun 12, 2018

Job #136 is now in scope, role is REV

@0crat
Copy link
Collaborator

0crat commented Jun 12, 2018

This pull request #136 is assigned to @llorllale/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job

@coveralls
Copy link

Pull Request Test Coverage Report for Build 251

  • 13 of 16 (81.25%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 82.599%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/amihaiemil/docker/RtLogs.java 5 8 62.5%
Totals Coverage Status
Change from base Build 249: -0.06%
Covered Lines: 356
Relevant Lines: 431

💛 - Coveralls

1 similar comment
@coveralls
Copy link

Pull Request Test Coverage Report for Build 251

  • 13 of 16 (81.25%) changed or added relevant lines in 4 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.06%) to 82.599%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/com/amihaiemil/docker/RtLogs.java 5 8 62.5%
Totals Coverage Status
Change from base Build 249: -0.06%
Covered Lines: 356
Relevant Lines: 431

💛 - Coveralls

@llorllale
Copy link
Contributor

@amihaiemil looks good

@amihaiemil
Copy link
Owner Author

@rultor merge it

@rultor
Copy link
Collaborator

rultor commented Jun 12, 2018

@rultor merge it

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 6e97d29 into master Jun 12, 2018
@rultor
Copy link
Collaborator

rultor commented Jun 12, 2018

@rultor merge it

@amihaiemil Done! FYI, the full log is here (took me 3min)

@amihaiemil amihaiemil deleted the 135 branch June 12, 2018 13:40
@0crat
Copy link
Collaborator

0crat commented Jun 12, 2018

Order was finished: +15 point(s) just awarded to @llorllale/z

@0crat
Copy link
Collaborator

0crat commented Jun 12, 2018

The job #136 is now out of scope

@0crat
Copy link
Collaborator

0crat commented Jun 12, 2018

Payment to ARC for a closed pull request, as in §28: +10 point(s) just awarded to @amihaiemil/z

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants