Skip to content

Conversation

amihaiemil
Copy link
Owner

@amihaiemil amihaiemil commented Aug 23, 2018

PR for #144

RtImages is abstract since we will have at least 2 implementations: ListedImages and SearchedImages, which will be iterated differently (use a different HTTP endpont).

Left a few puzzles for continuing implementation in different areas.

@0crat
Copy link
Collaborator

0crat commented Aug 23, 2018

Job #151 is now in scope, role is REV

@coveralls
Copy link

coveralls commented Aug 23, 2018

Pull Request Test Coverage Report for Build 284

  • 13 of 13 (100.0%) changed or added relevant lines in 3 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 83.153%

Totals Coverage Status
Change from base Build 280: 0.3%
Covered Lines: 385
Relevant Lines: 463

💛 - Coveralls

@amihaiemil amihaiemil changed the title FilteredImages Added ListedImages and made RtImages abstract Aug 23, 2018
@amihaiemil
Copy link
Owner Author

@rultor merge pls

@rultor
Copy link
Collaborator

rultor commented Aug 23, 2018

@rultor merge pls

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit cb46de7 into master Aug 23, 2018
@amihaiemil amihaiemil deleted the 144 branch August 23, 2018 12:31
@rultor
Copy link
Collaborator

rultor commented Aug 23, 2018

@rultor merge pls

@amihaiemil Done! FYI, the full log is here (took me 3min)

@0crat
Copy link
Collaborator

0crat commented Aug 23, 2018

Job gh:amihaiemil/docker-java-api#151 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Aug 23, 2018

The job #151 is now out of scope

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants