Skip to content

Conversation

llorllale
Copy link
Contributor

This PR is for #85:

  • Initial implementations of Networks and Network
  • Left puzzles to continue work

@0crat
Copy link
Collaborator

0crat commented Sep 11, 2018

Job #157 is now in scope, role is REV

@coveralls
Copy link

coveralls commented Sep 11, 2018

Pull Request Test Coverage Report for Build 294

  • 7 of 7 (100.0%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 81.159%

Totals Coverage Status
Change from base Build 293: 0.3%
Covered Lines: 392
Relevant Lines: 483

💛 - Coveralls

@0crat
Copy link
Collaborator

0crat commented Sep 11, 2018

@amihaiemil/z everybody who has role REV is banned at #157; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

Copy link
Owner

@amihaiemil amihaiemil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llorllale Nice, just a comment. I boosted the task, since this definetely looks like more than 30min :D

+ " \"Id\": \"13e871235c677f196c4e1ecebb9dc733b9b2d2ab589e30c539efeda84a24215e\",\n"
+ " \"Created\": \"0001-01-01T00:00:00Z\"\n"
+ " }\n"
+ "]"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llorllale Isn't it possible to build a JsonArray and call toString?

Json.createArrayBuilder()
    .add(...)
    .add(...)
    .build()
    .toString()

Normally, passing a direct String is better (theory-wise), since you're not involving other classes in the unit test, but I think it's safe to trust the javax.json implementstiond :D

Copy link
Contributor Author

@llorllale llorllale Sep 20, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amihaiemil I passed a string in order to mirror the docs more closely: basically just copy-pasted the example from the docs (minus irrelevant bits). Least amount of work and hassle.

Still want me to build it?

http,
new HttpGet(baseUri.toString().concat("/networks")),
RtNetwork::new
);
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llorllale This supplier is nice, I like it. I was actually struggling to find this solution at some point (can't remember where). I need to study Java 8 more, I guess...

@0crat
Copy link
Collaborator

0crat commented Sep 16, 2018

@amihaiemil/z everybody who has role REV is banned at #157; I won't be able to assign anyone automatically; consider assigning someone manually (as in §19), or invite more people (as in §51), or remove the job from the scope (as in §14)

@amihaiemil
Copy link
Owner

@llorllale I see. Let's leave it like this then.

@amihaiemil
Copy link
Owner

@rultor merge

@rultor
Copy link
Collaborator

rultor commented Sep 21, 2018

@rultor merge

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 761b49b into amihaiemil:master Sep 21, 2018
@rultor
Copy link
Collaborator

rultor commented Sep 21, 2018

@rultor merge

@amihaiemil Done! FYI, the full log is here (took me 3min)

@0crat
Copy link
Collaborator

0crat commented Sep 21, 2018

Job gh:amihaiemil/docker-java-api#157 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Sep 21, 2018

The job #157 is now out of scope

@llorllale llorllale deleted the 85 branch September 21, 2018 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants