-
-
Notifications
You must be signed in to change notification settings - Fork 55
(#85) RtNetworks, RtNetwork #157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Job #157 is now in scope, role is |
Pull Request Test Coverage Report for Build 294
💛 - Coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llorllale Nice, just a comment. I boosted the task, since this definetely looks like more than 30min :D
+ " \"Id\": \"13e871235c677f196c4e1ecebb9dc733b9b2d2ab589e30c539efeda84a24215e\",\n" | ||
+ " \"Created\": \"0001-01-01T00:00:00Z\"\n" | ||
+ " }\n" | ||
+ "]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llorllale Isn't it possible to build a JsonArray
and call toString
?
Json.createArrayBuilder()
.add(...)
.add(...)
.build()
.toString()
Normally, passing a direct String is better (theory-wise), since you're not involving other classes in the unit test, but I think it's safe to trust the javax.json
implementstiond :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amihaiemil I passed a string in order to mirror the docs more closely: basically just copy-pasted the example from the docs (minus irrelevant bits). Least amount of work and hassle.
Still want me to build it?
http, | ||
new HttpGet(baseUri.toString().concat("/networks")), | ||
RtNetwork::new | ||
); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@llorllale This supplier is nice, I like it. I was actually struggling to find this solution at some point (can't remember where). I need to study Java 8 more, I guess...
@llorllale I see. Let's leave it like this then. |
@rultor merge |
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
@amihaiemil Done! FYI, the full log is here (took me 3min) |
Job |
The job #157 is now out of scope |
This PR is for #85:
Networks
andNetwork