-
-
Notifications
You must be signed in to change notification settings - Fork 55
(#154) Filters for ListedImages #159
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Pull Request Test Coverage Report for Build 297
💛 - Coveralls |
Job #159 is now in scope, role is |
This pull request #159 is assigned to @llorllale/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
@amihaiemil I can't be REV :) |
@llorllale well, looks ok. We'll see about integration testing, later. I boosted the original task 6x now, that is the maximum according to the Policy :D |
@rultor merge it |
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
@amihaiemil Done! FYI, the full log is here (took me 3min) |
Order was finished: +15 point(s) just awarded to @llorllale/z |
The job #159 is now out of scope |
Payment to |
This PR is for #154:
ListedImages
according to the docs.This PR took me way longer than it looks. The documentation referenced above is not entirely clear, and searches for some examples yield filters not included in the documentation(!) (1, 2).
I have not tested this solution against a live docker instance, and I'm not quite satisfied both with the efficiency of the unit test I wrote, nor with the elegance of both the implementation and test.
¯\_(ツ)_/¯
Maybe we can add a puzzle for that. Maybe we can also wait for #153 and make sure this actually works when we implement integration tests for that.