(#169) Added new volume classes #190
Conversation
|
Job #190 is now in scope, role is |
|
This pull request #190 is assigned to @llorllale/z, here is why; the budget is 15 minutes, see §4; please, read §27 and when you decide to accept the changes, inform @amihaiemil/z (the architect) right in this ticket; if you decide that this PR should not be accepted ever, also inform the architect; this blog post will help you understand what is expected from a code reviewer; there will be no monetary reward for this job |
Pull Request Test Coverage Report for Build 330
💛 - Coveralls |
| * @author Marco Teixeira (marcoo.teixeira@gmail.com) | ||
| * @version $Id$ | ||
| * @since 0.0.1 | ||
| */ |
There was a problem hiding this comment.
@unstablemark looks like we need another puzzle here for implementing Volume?
There was a problem hiding this comment.
Please check the added puzzle (it's new for me), let me know if I need to change something.
| package com.amihaiemil.docker; | ||
|
|
||
| /** | ||
| * Volume API. |
There was a problem hiding this comment.
@unstablemark I'm not a fan of including "API" in the description of an... API. :)
I know @amihaiemil does it, and I know we have it elsewhere in this library. We could go either way on this.
There was a problem hiding this comment.
@llorllale I changed the description a little, let me know if you have a better ideia.
| * @version $Id$ | ||
| * @since 0.0.1 | ||
| * @todo #169:30min Extend Iterable of Volumes to and | ||
| * continue implementing the rest of the operations for the volume. |
There was a problem hiding this comment.
@unstablemark add a space before "continue", otherwise it'll fail the merge build
@amihaiemil let's add a pdd check on the travis build to catch issues like this
|
@llorllale/z this job was assigned to you 5days ago. It will be taken away from you soon, unless you close it, see §8. Read this and this, please. |
|
@rultor merge |
@llorllale Thanks for your request. @amihaiemil Please confirm this. |
|
@rultor merge |
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
@amihaiemil Done! FYI, the full log is here (took me 2min) |
|
The job #190 is now out of scope |
|
Order was finished: +15 point(s) just awarded to @llorllale/z |
|
Payment to |
6 participants
This PR is for #169 :