Skip to content

Conversation

bkuzmic
Copy link
Contributor

@bkuzmic bkuzmic commented Dec 6, 2018

PR for #172

@bkuzmic
Copy link
Contributor Author

bkuzmic commented Dec 6, 2018

@amihaiemil Intellij IDEA has once again "fixed" my imports. Do you have a layout schema for imports?

IDEA imports

@0crat
Copy link
Collaborator

0crat commented Dec 6, 2018

@bkuzmic/z this pull request is too small, just 8 lines changed (less than 10), there will be no formal code review, see §53 and §28; in the future, try to make sure your pull requests are not too small; @amihaiemil/z please review this and merge or reject

@amihaiemil
Copy link
Owner

@bkuzmic I formatted the puzzle (it has to be this format, otherwise 0pdd complains) and also referenced the initial Issue in the PR's descritiption.

Also, for the future, please don't use Github keywords like "closes" or "fixes" since the initial Issue will be closed automatically (by you) and then 0crat will complain: the ticket's reporter has to be the one that closes it :D

@amihaiemil
Copy link
Owner

@rultor merge it please

@rultor
Copy link
Collaborator

rultor commented Dec 6, 2018

@rultor merge it please

@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit 7d236d0 into amihaiemil:master Dec 6, 2018
@rultor
Copy link
Collaborator

rultor commented Dec 6, 2018

@rultor merge it please

@amihaiemil Done! FYI, the full log is here (took me 2min)

@0crat
Copy link
Collaborator

0crat commented Dec 6, 2018

Job gh:amihaiemil/docker-java-api#203 is not assigned, can't get performer

@0crat
Copy link
Collaborator

0crat commented Dec 6, 2018

This job is not in scope

@coveralls
Copy link

coveralls commented Dec 8, 2018

Pull Request Test Coverage Report for Build 355

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.6%) to 85.053%

Totals Coverage Status
Change from base Build 346: 0.6%
Covered Lines: 478
Relevant Lines: 562

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants