#38: Preparing LocalDocker for testing #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Added primary ctor to `LocalDocker` * Added `AssertRequest`, a mock HttpClient useful for testing requests * Fixed typo in interface `Docker`
amihaiemil
reviewed
Mar 13, 2018
| * @param client The http client to use. | ||
| * @param baseUri Base URI. | ||
| */ | ||
| LocalDocker(final HttpClient client, final URI baseUri) { |
There was a problem hiding this comment.
@llorllale Could you accept String version here, instead of URI baseUri, and move URI.create(...) in the call to super? I think it's more uniform, to have all ctors accepting the version and letting the object build the URI with the needed host :D
As per PR review: * The String version is now specified all the way up to the primary ctor of LocalDocker
|
@amihaiemil please check now |
|
@rultor merge it pls |
@amihaiemil OK, I'll try to merge now. You can check the progress of the merge here |
@amihaiemil Done! FYI, the full log is here (took me 2min) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as per #38:
This PR:
LocalDockerAssertRequest, a mock HttpClient useful for testing requestsDockerUnixHttpClientAssertRequest